feat: add send event method customization #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sentry issue: SNAPSHOT-WEBHOOK-1 |
|
But why do we need to add support for the |
ChaituVR
reviewed
Jul 17, 2023
| event.token = sha256(`${to}${serviceEventsSalt}`); | ||
| event.secret = sha256(`${to}${serviceEventsSalt}`); | ||
| const headerSecret = sha256(`${to}${process.env.SERVICE_EVENTS_SALT}`); | ||
| const url = to.replace('[PROPOSAL-ID]', event.id.split('/')[1]); |
There was a problem hiding this comment.
I feel this URL format is only useful for our case, others may not use it or we need to find a way to send event type
There was a problem hiding this comment.
True. We can and should add support to inject all the other parameters send in the post body as a query params placeholder. And we should also support head request
|
@aurelianoB What do you think about this? |
ChaituVR
approved these changes
Jul 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧿 Current issues / What's wrong ?
All http webhooks events are now sent via a
POSTmethod, andGETis not supported.This is the first step to get rid of this hardcoded piece of code: https://github.com/snapshot-labs/snapshot-webhook/blob/master/src/events.ts#L110-L115 , which is raising a lot of errors when sequencer has issues.
Fix #56
💊 Fixes / Solution
Support
GET,HEADand all other methods🚧 Changes
ALTER TABLE subscribers ADD COLUMN method VARCHAR(5) NOT NULL DEFAULT 'POST';)🛠️ Tests